Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) avoid catching Num key modifier on macOS #13481

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 18, 2024

fixes #13305

59b54da introduced a regression on macOS:
debugging in #13331 revealed that on macOS the arrow keys are sent with Num modifier, for which there would be no match in our keyseq/control hash.

Revert to checking the individual modifiers and cosntruct the QKeySequence with QStrings.

@ronso0
Copy link
Member Author

ronso0 commented Jul 19, 2024

Note: alternatively we could also check for
if (macOS && Num mod && (key == Up || key == Down || key == Left || key == Right))
and remove the Num mod in these cases.

Not sure if that's worth the effort.


And I'm not sure whether we should explicitly check for the Num mod in general. This would allow to use the numpad for shortcuts, too. But that's separate from this rather urgent bugfix.
Please someone check this and merge asap. Thanks!

@m0dB m0dB merged commit 23ace25 into mixxxdj:2.4 Jul 19, 2024
14 checks passed
@m0dB
Copy link
Contributor

m0dB commented Jul 19, 2024

I confirm the bug and the fix (I had no idea that shift left / shift right was supposed to load the track, very convenient indeed!).

@ronso0 ronso0 deleted the kbd-macos-num-fix branch July 19, 2024 22:51
@DJMaxergy
Copy link
Contributor

Tested and works for me on MacOS, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts for loading track from library into left/right deck not working anymore
3 participants