Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDJ: force-show decks 3/4 if we are going to use them #13455

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 9, 2024

Avoids potential of confusion if AutoDJ resorts to deck 3 and/or 4 while deck 1/2 are assigned to crossfader center.

(obviously doesn't cover the case where controller mappings request 4 decks but e.g. Shade skin can't show them)

Fixes: #13396

Copy link

github-actions bot commented Oct 8, 2024

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Oct 8, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 2400336 into mixxxdj:2.5 Oct 8, 2024
13 checks passed
@ronso0 ronso0 deleted the autodj-show-decks34 branch October 8, 2024 20:27
@ronso0 ronso0 added this to the 2.5.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodj library stale Stale issues that haven't been updated for a long time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants