Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPixmapStore: Change getPixmapNoCache to std::unique_ptr and further optimizations #13369

Merged
merged 8 commits into from
Jun 30, 2024
Merged

WPixmapStore: Change getPixmapNoCache to std::unique_ptr and further optimizations #13369

merged 8 commits into from
Jun 30, 2024

Conversation

JoergAtGithub
Copy link
Member

No description provided.

@github-actions github-actions bot added the ui label Jun 14, 2024
Swiftb0y
Swiftb0y reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits. Thank you for the cleanup

src/skin/legacy/legacyskinparser.cpp Outdated Show resolved Hide resolved
src/widget/paintable.cpp Outdated Show resolved Hide resolved
src/widget/wpixmapstore.cpp Outdated Show resolved Hide resolved
JoergAtGithub and others added 5 commits June 28, 2024 15:08
@JoergAtGithub
WPixmapStore: Change getPixmapNoCache to std::unique_ptr and further …
0e2a24f 
…optimizations
@JoergAtGithub @daschuer
auto* to indicate ptr
02fdc73 
Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
@JoergAtGithub @Swiftb0y
Use QStringLiteral instead of QString
2a2de2a 
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
@JoergAtGithub @Swiftb0y
Don't use .get()
183b35f 
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
@JoergAtGithub
Use std::unique_ptr instead of QScopedPointer and use std::move to tr…
5434ef0 
…ansfer it with ownership
@JoergAtGithub JoergAtGithub force-pushed the Optimize_WPixmapStore branch from ee2d09e to 5434ef0 Compare June 28, 2024 13:16
Swiftb0y
Swiftb0y reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits. thank you.

src/widget/wpixmapstore.cpp Show resolved Hide resolved
src/widget/wpixmapstore.cpp Outdated Show resolved Hide resolved
@JoergAtGithub JoergAtGithub force-pushed the Optimize_WPixmapStore branch 3 times, most recently from fe15b5c to ae1b4d8 Compare June 28, 2024 17:14
@JoergAtGithub JoergAtGithub force-pushed the Optimize_WPixmapStore branch from d2574fa to 6795f8a Compare June 28, 2024 18:36
Swiftb0y
Swiftb0y approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

src/util/opengltexture2d.cpp Outdated Show resolved Hide resolved
src/widget/wpixmapstore.h Outdated Show resolved Hide resolved
@JoergAtGithub @Swiftb0y
Use using instead of typedef
0712b0f 
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Swiftb0y
Swiftb0y approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Waiting for CI just in case.

@JoergAtGithub
Copy link
Member Author

@Swiftb0y This should be ready now!

@Swiftb0y
Copy link
Member

Yup, thanks for the extensive cleanup and the reminder.

@Swiftb0y Swiftb0y merged commit d3f420f into mixxxdj:main Jun 30, 2024
13 checks passed
@JoergAtGithub JoergAtGithub deleted the Optimize_WPixmapStore branch June 30, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer left review comments

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoergAtGithub @Swiftb0y @daschuer