Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressor effect fixes #13261

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

fonsargo
Copy link
Contributor

Fixes #13237

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and sounds good. Do your wish to rebase the PR to main and squash the fixup commits.

- Clear all buffers when enabling effect
- Change all coeffs if sample rate or buffer were changed
- Auto make up optimization
- Conversion from double fix
- Applying ramping gain for auto make up
- fix formatting
@fonsargo fonsargo force-pushed the compressor_effect_fixes branch from 9cbe709 to 8893814 Compare June 1, 2024 15:04
@fonsargo
Copy link
Contributor Author

fonsargo commented Jun 1, 2024

Rebased and squashed

@acolombier
Copy link
Member

@daschuer merge?

@daschuer
Copy link
Member

yes.

@daschuer daschuer merged commit 1f85c9c into mixxxdj:main Jun 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compressor effect: Adjust Makeup Time constant
3 participants