MIDI for light: Fix unsound timer handling #13117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
commented
Apr 17, 2024
| engine.stopTimer(midi_for_light.deck_beat_watchdog_timer[0]); | ||
| engine.stopTimer(midi_for_light.deck_beat_watchdog_timer[1]); | ||
| engine.stopTimer(midi_for_light.deck_beat_watchdog_timer[2]); | ||
| engine.stopTimer(midi_for_light.deck_beat_watchdog_timer[3]); |
There was a problem hiding this comment.
Note that this likely didn't work in the first place. deck_beat_watchdog_timer is a free variable, not a member of midi_for_light. It was probably never noticed being part of the rarely invoked shutdown handler.
There was a problem hiding this comment.
The error can be reproduced by selecting the MIDI for light mapping and then switching to another mapping (which errors)
The `[-1, -1]` value is likely taken from other scripts where the variable actually holds an array of timers. This is not the case here, so to prevent confusion, we shouldn't use an array where we intend to assign a timer.
fd9470d to
9cfdbd6
Compare
This should fix the remaining "Tried to kill non-existent timer" errors.
Swiftb0y
approved these changes
Jul 11, 2024
|
Should this be merged then? |
|
Yes |
|
Ah this still targeted 2.4, so we might need another merge to 2.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at fixing #13114.
Maybe someone more familiar with the legacy controller scripting system can comment on this, the timer handling in the script did not look sound, so I tried to ensure that timers are only stopped if they are running and that they are unassigned properly if stopped.