Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping for Behringer controllers DDM4000 & BCR2000 #12969

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Fix mapping for Behringer controllers DDM4000 & BCR2000 #12969

merged 5 commits into from
Mar 19, 2024

Conversation

git-developer
Copy link
Contributor

This PR fixes a bug introduced by commit 306bbe4 (PR #12401) that covers the switch to QJSEngine for v2.4.

When an affected controller (Behringer DDM4000 or BCR2000) is configured, the following message is shown on application start of v2.4.0:

Warning [Controller] ControllerScriptHandlerBase:
"Uncaught exception: file:///usr/share/mixxx/controllers/Behringer-Extension-scripts.js:244:
TypeError: Property 'disable' of object [object Object] is not a function
Backtrace: @file:///usr/share/mixxx/controllers/Behringer-Extension-scripts.js:244"

With the suggested patch applied, no error is shown and the controllers work as expected.

Probably related: #11473

/cc @Swiftb0y @JoergAtGithub

@JoergAtGithub
Copy link
Member

A case which is not covered by #12437 yet

@git-developer
Copy link
Contributor Author

Root cause is QTBUG-95677, see #11473 (comment) for details.

@JoergAtGithub JoergAtGithub requested a review from Swiftb0y March 18, 2024 20:36
@git-developer git-developer mentioned this pull request Mar 19, 2024
Closed
Swiftb0y
Swiftb0y reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

README.md Outdated
bug list][easybugs] and get started!
bug list][easybugs] and get started!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It was required for the CI build.

@JoergAtGithub
Copy link
Member

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit c2ecb8e into mixxxdj:2.4 Mar 19, 2024
14 checks passed
@git-developer git-developer deleted the fix/controller-behringer branch March 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y left review comments

Assignees
No one assigned
Labels
controllers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-developer @JoergAtGithub @Swiftb0y