Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hdpi rounding for GLSL waveforms #12731

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Hdpi rounding for GLSL waveforms #12731

merged 4 commits into from
Feb 8, 2024

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Feb 5, 2024

This fixes the rounding to device pixel to avoid visual interference at 125 % display scaling.
Fixes one part of #12601

@daschuer
Copy link
Member Author

daschuer commented Feb 7, 2024

@toszlanyi has confirmed that this fixes the issue for him usiing the all shader waveforms.

@daschuer daschuer changed the title Hdpi rounding for waveform marks Hdpi rounding for GLSL waveforms Feb 7, 2024
@ronso0
Copy link
Member

ronso0 commented Feb 8, 2024

@m0dB Do you have time to take a look?

@ronso0 ronso0 requested a review from m0dB February 8, 2024 12:41
@m0dB
Copy link
Contributor

m0dB commented Feb 8, 2024

LGTM

@m0dB m0dB merged commit 6e4dad4 into mixxxdj:2.4 Feb 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants