Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Track rating: simplify by moving some logic from WStarRating to BaseTrackPlayerImpl #12648

Merged
merged 1 commit into from
Apr 15, 2024
Merged

(fix) Track rating: simplify by moving some logic from WStarRating to BaseTrackPlayerImpl #12648

merged 1 commit into from
Apr 15, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 27, 2024

as proposed in #12591 (comment)

@ronso0 ronso0 mentioned this pull request Jan 27, 2024
Merged
@ronso0 ronso0 force-pushed the track-rating-consolidation branch from d2ab9d6 to 103f6ed Compare January 29, 2024 02:29
@ronso0 ronso0 marked this pull request as ready for review January 29, 2024 02:29
@ronso0 ronso0 mentioned this pull request Jan 30, 2024
Merged
@ronso0 ronso0 force-pushed the track-rating-consolidation branch from 103f6ed to e4ce362 Compare January 30, 2024 13:20
@ronso0 ronso0 mentioned this pull request Apr 2, 2024
Closed
@ronso0 ronso0 linked an issue Apr 2, 2024 that may be closed by this pull request
One can give an empty deck a star rating #13037
Closed
@ronso0 ronso0 added this to the 2.4.1 milestone Apr 2, 2024
@ronso0 ronso0 changed the title Track rating: simplify by moving some logic from WStarRating to BaseTrackPlayerImpl (fix) Track rating: simplify by moving some logic from WStarRating to BaseTrackPlayerImpl Apr 2, 2024
@ronso0
Copy link
Member Author

ronso0 commented Apr 2, 2024

fixes #13037 btw

daschuer
daschuer approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Thank you.

@daschuer daschuer merged commit 36397e2 into mixxxdj:2.4 Apr 15, 2024
14 checks passed
@ronso0 ronso0 deleted the track-rating-consolidation branch April 15, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality library ui
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

One can give an empty deck a star rating
2 participants
@ronso0 @daschuer