Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intro/Outro cues and silence detection #1242
Intro/Outro cues and silence detection #1242
Changes from 23 commits
99994dc
871474b
b118d49
555911a
bed7843
6587080
54cc99f
0f583b9
b8ecf19
095dd81
a5b22b5
90f2c81
d5385e5
aee31e0
6eaa83d
49888d7
666068d
59f19eb
20f8796
d0f1d90
92b79f1
f95c646
4889fa2
87a3e04
8c01dd0
416bc08
f971053
3ebfdc2
4d27845
43c6441
4472462
13ffd54
64082c0
784c9f8
259a169
83766c0
44beb4c
8dacede
e7fb679
e09f369
865e454
221b5a4
6a41779
7dab7fd
3ab12a3
98828b9
227ebe8
ad1bf43
7959376
d5bdb64
c42089c
f5aeeba
fbc60e7
7f16257
ddeee23
24e9099
2b2da0c
35707a4
638cad8
032c1c0
c2916dc
e6a0112
e89a753
d6cfc92
ae26278
4b07a89
84b774c
310e4c5
70f0f32
24f137d
1a2d5c1
fa95569
a61ac72
8a9f716
bd92970
3a6e8dc
02332e7
9250a74
667370a
586d331
3b51ac4
d36ee69
10bb36e
2ab4adb
468017e
fd4d979
6d7d523
a8d66a7
e9923a6
2913cdd
f345515
bd5a5a4
58565ee
2a75438
6f50e4c
86fae61
1ba11bd
6ed59d5
028fc57
cbefc58
da03ecb
21b51f9
39acb51
cbb2eb2
4f29098
fa3855c
b345adc
59d20a8
f1d887f
4ebecca
e827104
425bb20
cc24260
0ddf621
2aa9f99
e69e41a
090e1ca
788c67a
d8d4875
a7cfbd5
e4f0d5a
ce04bfa
ee4ab9e
acc6b4c
014a55f
1341ef1
25a67d9
807c180
7a7e3e5
65dc18e
8cc7d9d
1cd3fcc
55307f7
60d5326
bbf985a
edbbf3c
fcdff0f
eb03b2f
9dbac85
4923a2a
36b4418
57a922d
6b36e82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No indent for namespaces and prefer to use constexpr instead of const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work?
constexpr float kSilenceThreshold = db2ratio(-60.0f);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the CUE relevant here?
You may wrap this into a function with an explaining name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle m_iSignalBegin < 0 and m_iSignalEnd < 0 explicitly here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to store a TrackPointer and you should not modify the track while processing. If the analysis is aborted you end up with an inconsistent state!
The track must be modified in finalize() which provides the TrackPointer.