Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracks table: dont wrap around if Shift is pressed #12391

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Tracks table: dont wrap around if Shift is pressed #12391

merged 1 commit into from
Dec 8, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 3, 2023

Closes #12121

@robbert-vdh Does this conflict somehow with the key sort use case?

@ronso0 ronso0 changed the base branch from main to 2.4 December 3, 2023 23:50
@ronso0 ronso0 closed this Dec 3, 2023
@ronso0 ronso0 reopened this Dec 3, 2023
robbert-vdh
robbert-vdh approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@robbert-vdh robbert-vdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this conflict somehow with the key sort use case?

No that should be fine!

ywwg
ywwg approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@JoergAtGithub
Copy link
Member

Works on Windows too. Code LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 1463a7b into mixxxdj:2.4 Dec 8, 2023
17 of 21 checks passed
@ronso0 ronso0 deleted the tracks-dont-wrap-around-with-shift branch December 8, 2023 21:26
@ronso0 ronso0 mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywwg ywwg ywwg approved these changes

@robbert-vdh robbert-vdh robbert-vdh approved these changes

Assignees
No one assigned
Labels
code quality ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track table: don't wrap around while shift is pressed
4 participants
@ronso0 @JoergAtGithub @robbert-vdh @ywwg