Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deere: add 'Sync Leader' button #12234

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 28, 2023

off leader follower
image image image

@github-actions github-actions bot added the skins label Oct 28, 2023
@daschuer
Copy link
Member

Did you consider to use a crown like symbol like in LateNight? This would simplify the manual.

@ronso0
Copy link
Member Author

ronso0 commented Oct 30, 2023

True, a distinct icon for all skins would be preferred.
Of course I considered the crown but the buttons in Deere is small (SYNC is 18 px tall) and cramming a rather detailed crown icon into such a small square button didn't feel like a good idea.
Though, making the crown a borderless button could work (would be the only top-level button without a border).

@ronso0
Copy link
Member Author

ronso0 commented Oct 30, 2023

buttons in Deere is small (SYNC is 18 px tall) and cramming a rather detailed crown icon into such a small square button didn't feel like a good idea.

Okay, actually it worked. See first post for screenshots.

@ronso0 ronso0 force-pushed the deere-sync-leader branch from c033805 to 82089b1 Compare October 30, 2023 15:21
@daschuer
Copy link
Member

Great, Thank you.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@JoergAtGithub
Copy link
Member

Tested this on Windows11 and it works as expected. But the crown symbol doesn't look as in your screenshots:
grafik
Screen resolution of my laptop is 1920x1200.

@ronso0
Copy link
Member Author

ronso0 commented Oct 30, 2023

But the crown symbol doesn't look as in your screenshots:

I saw that intermediately, too. I suspect it's related to 'Optimized SVG' so I saved them as plain SVG.
Seems there was a leftover stroke color, even though I don't see it here. I also removed some off-screen path.
Please try again.

@ronso0 ronso0 force-pushed the deere-sync-leader branch from 82089b1 to a9ef400 Compare October 30, 2023 22:22
@JoergAtGithub
Copy link
Member

Now it looks even more broken:
grafik

@ronso0 ronso0 force-pushed the deere-sync-leader branch from a9ef400 to 373eb83 Compare October 30, 2023 23:57
@ronso0
Copy link
Member Author

ronso0 commented Oct 30, 2023

Pleae try again.
It seems there are conflicting residues even when pasting a path into a new document with Inkscape (single style elements).

@JoergAtGithub
Copy link
Member

Now it looks correct on Windows11 too! Thank you!

@JoergAtGithub JoergAtGithub merged commit cc7919d into mixxxdj:2.4 Oct 31, 2023
@ronso0 ronso0 deleted the deere-sync-leader branch October 31, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants