macOS packaging: Enable app sandbox in ad-hoc-packaged (i.e. non-notarized) bundles too #12101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that users will now get this warning instead: 
This warning, however, only shows up once (as opposed to the dialog discussed in #12098). |
|
Note that the standard Gatekeeper workflow of having to double-click the app once to get 
and then having to right-click -> Open to get 
...still applies. Nothing special to see here, this is how macOS treats every non-notarized app. |
daschuer
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4774 and specifically e922329 we set up ad-hoc signing for (non-notarized) macOS builds in a way that neither uses the hardened runtime nor app sandbox.
Apparently, macOS Sonoma will prompt the user at every launch when a non-sandboxed app accesses a sandboxed path, even of the app itself (
~/Library/Containers/org.mixxx.mixxx/...). See #12098 and this blog post for details.For this reason, this PR passes the entitlements, and thus enables app sandbox, in ad-hoc-signed builds too (note that we'll still leave the hardened runtime disabled for now), which should fix the issue.