Skins: Remove border: 0px from sidebar item styling
#11970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Changes LGTM
The original reason for these outline: none, padding/margin: 0px, border: 0px was to overwrite (custom/unofficial) OS themes' stylesheets. We'll never know if that is indeed relevant nowadaysbecause a) users need to recognize these potential unintended styles as unintended (by Mixxx) and b) care enough to take the time writing a report.
That being said, if adding border: 0px was too excessive and has the opposite effect (why?) with (some) macOS versions and removing it fixes the issue you saw... fine 🤷
Thanks for bisecting btw!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11957
cc @ronso0