-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't mark software waveforms legacy #11918
don't mark software waveforms legacy #11918
Conversation
Thank you. That's already good. Need to test. |
Yes, I'm on it, currently being held up by a little bigger refactoring to make the change straightforward. |
b83d539
to
cfdbb34
Compare
cfdbb34
to
626a4ea
Compare
ready for review |
I'd like to take a look but don't have the time to build, @Swiftb0y do you mind posting a screenshot of the new list? |
Thanks, looks like a good step forward! Though, these are indeed still way too many choices for beginners, and even advanced users I'd say. 🤪 |
Sure, but thats not my area of expertise. Would you prefer to postpone it or do you want it in this PR? I'd appreciate a PR to my branch then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for going the extra mile. This looks good for me.
@ronso0, merge? |
// 30FPS is the default | ||
frameRateSlider->setValue(30); | ||
// 60FPS is the default | ||
frameRateSlider->setValue(60); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
75FPS displays get info fashion now, we should probably expand the possible framerate to 120FPS soon, also variable refresh rates are a thing now and might be interesting for us (though probably only relevant for games that have exclusive access to a display device)
Sure, the list looks much better now, and I trust both of you wrt the code.
I'm just sharing my ideas for further improvement, though those should go to #11915 |
Thanks everybody. |
as discussed in #11915
Anything else you'd like to see implemented?