iTunes: Permit duplicate playlist names by identifying playlists by id (rather than name) #11794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: I am targeting 2.4 for this since it's a rather minor addition to the "new" iTunes feature in 2.4, feel free to comment on whether that's fine or if I should retarget to |
daschuer
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches the iTunes feature to identify playlists by id rather than their name and updates the created
TreeItems to also use the original, non-suffixed names (without... #n). Given that the corresponding database column has aUNIQUEconstraint, the suffixed name will still be used there for backwards compatibility/to avoid a schema change, but no longer presented in the UI.Thus if the user e.g. has two playlists named
A, they will now both be presented asAin the sidebar, rather thanAandA #2, which generally looks cleaner since it mirrors the "original" naming of the playlists.For comparison: