Fix sharp cut transition after cueing a track without a defined intro #11629
Conversation
This fixes a bug where a micro seek causes a minimal intro which leads to sharp transition.
|
I need when I find time. |
|
I could not reproduce the issue using the PC only, also toggling quantize does not trigger it, but a micro movement on the jog wheel can reproduce the issue. |
|
I just tried on Windows and it's perfect !! Thanx!! |
| // Limit the intro length that results from a revers seek | ||
| // to a reasonable values. If the seek was too big, ignore it. | ||
| introLength = introEnd - toDeckStartSeconds; | ||
| if (introLength > (introEnd - introStart) * 2 && | ||
| introLength > (introEnd - introStart) + m_transitionTime && | ||
| introLength > outroLength) { | ||
| introLength = 0; |
There was a problem hiding this comment.
why this limitation? IIUC if the user seeks far before the intro, then this will just skip the fade, does this make sense? Why would this be desirable?
There was a problem hiding this comment.
Imagine a live recording with some introduction words.
The user probably has marked an intro when the music starts. Without this change and with a previous track without an outro the loooong intro time is used for fading if it is cued at 0:00. This is likely not desired. Now the transition time from the spin box is used in this case.
The other use case is the part of the bug fix. If the track is cued at intro start and the user touches the jog for a small seek. The intro is still used.
There was a problem hiding this comment.
Makes sense I guess. I just worry about the complexity this introduces. AutoDJ is already quite unpredictable IMO and this doesn't make it any better.
There was a problem hiding this comment.
It's also a drop in the bucket, so who cares...
This fixed #11621
It also adds a plausibility check for the intro length. Reject intros that are extended by more than the original length or by the transition time.