Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qt_assert when opening preferences #11454 #11456

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Apr 8, 2023

This fixes #11454

@github-actions github-actions bot added the ui label Apr 8, 2023
@daschuer daschuer changed the title debug the qt_assert from https://github.com/mixxxdj/mixxx/issues/11454 Fix qt_assert when opening preferences #11454 Apr 8, 2023
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks. LGTM otherwise.

src/preferences/effectmanifesttablemodel.cpp Outdated Show resolved Hide resolved
src/preferences/effectmanifesttablemodel.cpp Outdated Show resolved Hide resolved
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
@daschuer
Copy link
Member Author

daschuer commented Apr 8, 2023

Done.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Would you @JoergAtGithub be able to verify whether this is fixing the issue?

@daschuer
Copy link
Member Author

Friendly ping @JoergAtGithub

@Swiftb0y
Copy link
Member

Seems like Jörg is busy. Lets just merge regardless.

@Swiftb0y Swiftb0y merged commit 5645899 into mixxxdj:2.4 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants