fix(soundsourceflac): Fix -Wswitch when building with FLAC >= 1.4.0
#10921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44b48f0 to
63bec04
Compare
63bec04 to
6c2f5a4
Compare
Fixes the following warning:
src/sources/soundsourceflac.cpp: In member function ‘void mixxx::SoundSourceFLAC::flacError(FLAC__StreamDecoderErrorStatus)’:
src/sources/soundsourceflac.cpp:571:12: error: enumeration value ‘FLAC__STREAM_DECODER_ERROR_STATUS_BAD_METADATA’ not handled in switch [-Werror=switch]
571 | switch (status) {
| ^
The enumeration value has been mentioned in the FLAC 1.3.4 to 1.4.0
porting guide:
https://xiph.org/flac/api/group__porting__1__3__4__to__1__4__0.html
6c2f5a4 to
017bdd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following warning:
The enumeration value has been mentioned in the FLAC 1.3.4 to 1.4.0 porting guide:
https://xiph.org/flac/api/group__porting__1__3__4__to__1__4__0.html