workaround qt 5.12 bug for simulated rightbutton mouse events #10869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Sep 5, 2022
| @@ -117,6 +122,13 @@ bool MixxxApplication::notify(QObject* target, QEvent* event) { | |||
| mouseEvent->setButton(Qt::RightButton); | |||
| m_rightPressedButtons++; | |||
| } | |||
| if (mouseEvent->button() == Qt::RightButton && mouseEvent->buttons() == Qt::LeftButton) { | |||
There was a problem hiding this comment.
Workarounds for specific Qt releases should be enclosed in #ifef guards and restricted to only the Qt versions that are actually affected.
There was a problem hiding this comment.
got it. it also also platform specific, so i will guard that too.
There was a problem hiding this comment.
If you search the code you will find some common patterns involving QT_VERSION_CHECK etc.
|
@uklotzde i have added the guards as requested. |
daschuer
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt 5.12.3 has a bug which results in missing mouse button release events for simulated right clicks (ctrl+left click). Details of the exact bug can be found here: https://mixxx.zulipchat.com/#narrow/stream/109171-development ; see comments about the call to QApplicationPrivate::pickMouseReceiver from QWidgetWindow and the call to QWindowSystemInterface::handleMouseEvent from qnsview_mouse.mm
Fixing this with a patched Qt 5.12.3 would be desirable, but this workaround allows continuing with the existing build-env for 2.3, by correcting the event when it is handled by MixxxApplication::notify(...), effectively having the same result.