Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last track not visible in tracks view #9495

Closed
mixxxbot opened this issue Aug 23, 2022 · 22 comments · Fixed by mixxxdj/vcpkg#72
Closed

Last track not visible in tracks view #9495

mixxxbot opened this issue Aug 23, 2022 · 22 comments · Fixed by mixxxdj/vcpkg#72

Comments

@mixxxbot
Copy link
Collaborator

Reported by: amy-skerry
Date: 2018-10-30T02:47:13Z
Status: Confirmed
Importance: High
Launchpad Issue: lp1800577
Attachments: [Screen Shot 2018-10-29 at 7.43.49 PM.png](https://bugs.launchpad.net/bugs/1800577/+attachment/5207005/+files/Screen Shot 2018-10-29 at 7.43.49 PM.png), [Screen Shot 2018-10-30 at 6.38.00 PM.png](https://bugs.launchpad.net/bugs/1800577/+attachment/5207323/+files/Screen Shot 2018-10-30 at 6.38.00 PM.png), mix-listing-bug.jpg


macos 10.13.3
2.9 GHz Intel Core i5

The last track in the tracks view is not visible because it is blocked by the horizontal scroll bar. You can see a tiny bit of the track peeking above the scroll (see attached).

@mixxxbot
Copy link
Collaborator Author

Commented by: amy-skerry
Date: 2018-10-30T02:47:13Z
Attachments: [Screen Shot 2018-10-29 at 7.43.49 PM.png](https://bugs.launchpad.net/mixxx/+bug/1800577/+attachment/5207005/+files/Screen Shot 2018-10-29 at 7.43.49 PM.png)

@mixxxbot
Copy link
Collaborator Author

Commented by: amy-skerry
Date: 2018-10-30T02:50:49Z


Actually, I see the same behavior for other scroll bars, not just the tracks display. I believe the reason is that I have scroll bars set to always show (a MacOS setting).

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2018-10-30T12:31:25Z


Thanks for reporting this!

Which Mixxx version are you using?
Does the horizontal scrollbar disappear if you hide/resize table columns until you have blank space at the far right?

I notice the table header font didn't scale properly. Could you please post a screenshot of Tango skin?

@mixxxbot
Copy link
Collaborator Author

Commented by: amy-skerry
Date: 2018-10-31T01:38:56Z
Attachments: [Screen Shot 2018-10-30 at 6.38.00 PM.png](https://bugs.launchpad.net/mixxx/+bug/1800577/+attachment/5207323/+files/Screen Shot 2018-10-30 at 6.38.00 PM.png)


Which Mixxx version are you using?
Built from source on master

Does the horizontal scrollbar disappear if you hide/resize table columns until you have blank space at the far right?
Yep! If I remove columns such that no horizontal scroll is needed, the scrollbar goes away (and I can see the final track)

I notice the table header font didn't scale properly. Could you please post a screenshot of Tango skin?
I can repro with Tango skin as well (attached)

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2018-10-31T02:33:01Z


Considering this happens with other scrollbars, I suspect this is a bug in Qt. Do you use any other Qt applications? Have you noticed the same issue with those? What version of Qt did you build with and how did you install it?

@mixxxbot
Copy link
Collaborator Author

Commented by: amy-skerry
Date: 2018-10-31T03:38:13Z


Do you use any other Qt applications? Have you noticed the same issue with those?
Hm, I think RStudio uses Qt and while I didn't find the identical bug, I do observe a different scrolling bug in their file viewer.

What version of Qt did you build with and how did you install it?
5.10.1 installed view homebrew (brew install qt5)

I realized I was mistaken before when I said I had my MacOs settings set to always show scrollbars. Setting to "always show" actually eliminates the problem, whereas the problem emerges under the default "auto show" setting.

@mixxxbot
Copy link
Collaborator Author

mixxxbot commented Aug 23, 2022

Commented by: ronso0
Date: 2020-09-08T10:08:38Z


Unfortunately I now also experience this
Ubuntu 20.04
Mixxx 2.3beta with Qt5.12.8

Didn't yet check if this is tracked upstream(Qt).
Possible quick hack:
QTableView::item:last { padding-bottom: 1em; }

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-08T10:50:07Z


strange, I'm sure I saw it but can't reproduce it anymore..

@mixxxbot
Copy link
Collaborator Author

Commented by: aaronsav
Date: 2020-09-08T14:15:28Z
Attachments: mix-listing-bug.jpg


Its worrying that you cannot reproduce it but here is a screenshot showing the problem on a Macbook Pro Retina 15 inch screen using MacOS 10.15.6, and using Mixx 2.2.3 (build 2.2 r6750).

The listing is scrolled to the very bottom and you can just see the obscured final track highlighted by pressing the down arrow to reach it. This is the All Tracks view but it happens on every view where the number of tracks is greater than the unscrolled space and where the columns are larger than the available width which produces the horizontal scroll bar at the bottom to obscure the final track.

I hope that helps.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-09-08T17:22:04Z


Compared to my setup, with Ubuntu Bionic 18.04 and QT 5.9.5 the scrollbars are inside the content area and inside the borders changing colors when focused.

My guess is that this has changed with a QT update.

@mixxxbot
Copy link
Collaborator Author

mixxxbot commented Aug 23, 2022

Commented by: daschuer
Date: 2020-09-08T18:03:55Z


I think as a band aid, we should add just an empty line at the end.
This will probably also fix the painting issue with the star rating and the last track in the list.
#7304

What do you think?

@daschuer
Copy link
Member

daschuer commented Jun 6, 2023

I still cannot reproduce this with Ubuntu Focal Mixxx 2.5-alpha Qt 6.2.3 / Qt 5.12.8
grafik
There is always an empty square between the scoll-bars.

@foss-
Copy link
Contributor

foss- commented Jun 8, 2023

Cannot reproduce on macOS 13.4, Mixxx 2.5-alpha-40-g24eee4547c (main).

@mkukawski could you try a main build and see if the issue is persisting for you then?
https://mixxx.org/download/#testing

@daschuer daschuer added the macos label Jun 8, 2023
@ronso0
Copy link
Member

ronso0 commented Jun 8, 2023

FWIW this is the Qt bug https://bugreports.qt.io/browse/QTBUG-98289
Fixed in Qt 6.2.3 qt/qtbase@e0f8cad

@foss-
Copy link
Contributor

foss- commented Jun 12, 2023

Fix confirmed in Mixxx 2.4.0-beta 5c86074 (vcpkg_update_direct)
macOS 13.4, intel mac.

@daschuer
Copy link
Member

@foss- Cool, thank you. Can you also confirm that the issue comes back when using the 2.4.0 branch?

@foss-
Copy link
Contributor

foss- commented Jun 12, 2023

Curiously I can also not reproduce with 2.4-beta-16-gf9b3822135 🤔

@daschuer
Copy link
Member

Did you test all Skins/Styles? Maybe it depends on the Mac version or display setting?
At least you have confirmed that this patch is doing no harm.
A confirmation from the original reporter would really help.

@daschuer
Copy link
Member

@Aaronsav can you still confirm the issue?

@mkukawski
Copy link

mkukawski commented Jun 14, 2023 via email

@daschuer
Copy link
Member

Thank you for confirming. So we should merge mixxxdj/vcpkg#72

daschuer added a commit to daschuer/mixxx that referenced this issue Jun 20, 2023
This fixes the macOS scrollbar issue mixxxdj#9495
@daschuer daschuer added this to the 2.4.0 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants