Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Reanalyze with (dynamic) variable/constant BPM does no longer honor override #11872

Closed
fwcd opened this issue Aug 26, 2023 · 2 comments
Closed

Regression: Reanalyze with (dynamic) variable/constant BPM does no longer honor override #11872

fwcd opened this issue Aug 26, 2023 · 2 comments
Labels
bug confirmed regression
Milestone
2.4.0

Comments

@fwcd
Copy link
Member

fwcd commented Aug 26, 2023

Bug Description

Right-clicking a track and selecting Reanalyze > Reanalyze (variable BPM) (or Reanalyze (constant BPM) ) does not honor this override and uses the user setting instead.

This regression seems to have been introduced in a547664...f58dede:

Last good: a547664420 from 2023-08-13 21:20:02 +0200 (Merge branch '2.4' of github.com:mixxxdj/mixxx)
First bad: f58dede759 from 2023-08-17 23:59:45 +0200 (Merge branch '2.4' of github.com:mixxxdj/mixxx)

Version

f58dede

OS

macOS 13.5
@fwcd fwcd added the bug label Aug 26, 2023
@fwcd
Copy link
Member Author

fwcd commented Aug 26, 2023

This seems to have introduced the issue:

1d7eadb#diff-d5a2056b2bfeb0495c1927aaf64f90ff33b1557f4fc13ad42a03ba9337210e9dL146-R147

Since AnalyzerTrack can implicitly be constructed from TrackPointer this is easy to overlook. (Perhaps we should make the AnalyzerTrack constructor explicit?)

@Holzhaus

fwcd added a commit to fwcd/mixxx that referenced this issue Aug 26, 2023
@fwcd
AnalyzerThread: Pass AnalyzerTrack correctly again
d1893e2 
See mixxxdj#11872
fwcd added a commit to fwcd/mixxx that referenced this issue Aug 26, 2023
@fwcd
AnalyzerTrack: Make constructor explicit
92dec00 
To prevent accidentally passing just the track and thereby discarding
option overrides.

See mixxxdj#11872 (comment)
fwcd added a commit to fwcd/mixxx that referenced this issue Aug 26, 2023
@fwcd
AnalyzerTrack: Make constructor explicit
884e90a 
To prevent accidentally passing just the track and thereby discarding
option overrides.

See mixxxdj#11872 (comment)
@fwcd fwcd mentioned this issue Aug 26, 2023
Merged
@Swiftb0y
Copy link
Member

Thank you. closed by #11873 IIUC

@daschuer daschuer added this to the 2.4.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed regression
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
3 participants
@daschuer @Swiftb0y @fwcd