Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traktor Kontrol S2 MK3 mapping broken in 2.4+ #11461

Closed
mccowanm opened this issue Apr 10, 2023 · 0 comments
Closed

Traktor Kontrol S2 MK3 mapping broken in 2.4+ #11461

mccowanm opened this issue Apr 10, 2023 · 0 comments
Labels
Milestone

Comments

@mccowanm
Copy link

Greets. 1st time issue posting in mixxx ...
the DataView approach used in the updated res/controllers/common-hid-packet-parser.js causes type errors when the functions using DataView are passed a 'data' array from Traktor-Kontrol-S2-MK3-hid-scripts.js.
Following is a fix (tested against HEAD); haven't done a PR as not sure if it's the most elegant way, particularly if other controllers will be in a similar boat.

--- a/res/controllers/Traktor-Kontrol-S2-MK3-hid-scripts.js
+++ b/res/controllers/Traktor-Kontrol-S2-MK3-hid-scripts.js
@@ -225,7 +225,7 @@ TraktorS2MK3.registerInputPackets = function() {
     }
 
     // Dirty hack to set initial values in the packet parser
-    const data = [1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0];
+    const data = new Uint16Array([1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]);
     TraktorS2MK3.incomingData(data);
 };

fantastic project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants