Merge pull request #13903 from fwcd/handle-notify-target-null

MixxxApplication: Handle nullptr targets in notify
mixxxdj · Nov 19, 2024 · 6f94fd0 · 6f94fd0
2 parents 9a57502 + 18082d9
commit 6f94fd0
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/mixxxapplication.cpp b/src/mixxxapplication.cpp
@@ -14,6 +14,7 @@
 #include "soundio/soundmanagerutil.h"
 #include "track/track.h"
 #include "track/trackref.h"
+#include "util/assert.h"
 #include "util/cache.h"
 #include "util/cmdlineargs.h"
 #include "util/color/rgbcolor.h"
@@ -199,6 +200,11 @@ bool MixxxApplication::notify(QObject* pTarget, QEvent* pEvent) {
 
     bool ret = QApplication::notify(pTarget, pEvent);
 
+    VERIFY_OR_DEBUG_ASSERT(pTarget != nullptr) {
+        qWarning() << "Processed" << pEvent->type() << "for null pointer, this is probably a bug!";
+        return ret;
+    }
+
     if (m_isDeveloper &&
             time.elapsed() > kEventNotifyExecTimeWarningThreshold) {
         QDebug debug = qDebug();