Skip to content

Commit

Permalink
CoreAudio MP3 offsets for Serato cues
Browse files Browse the repository at this point in the history
  • Loading branch information
@ehendrikd
ehendrikd committed Apr 21, 2020
1 parent 231c686 commit 60120aa
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion src/track/serato/tags.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,18 @@ double SeratoTags::findTimingOffsetMillis(const QString& filePath) {

// TODO: Find missing timing offsets
switch (timingShiftCase) {
#if defined(__MAD__) || defined(__FFMPEG__)
#if defined(__COREAUDIO__)
case EXIT_CODE_CASE_A:
timingOffset = -12;
break;
case EXIT_CODE_CASE_B:
timingOffset = -40;
break;
case EXIT_CODE_CASE_C:
case EXIT_CODE_CASE_D:
timingOffset = -60;
break;
#elif defined(__MAD__) || defined(__FFMPEG__)
// Apparently all mp3guessenc cases have the same offset for MAD
// and FFMPEG
default:
Expand Down

3 comments on commit 60120aa

@bengl3rt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually close to what I was seeing when I attempted this testing (around 50ms for all but case A), but I didn't consider it plausible for the timings to be so different (> 20ms starts to be audible) so I had set about finding a scientific way to prove it... glad to know I'm not crazy!

@Be-ing
Copy link
Contributor

@Be-ing Be-ing commented on 60120aa Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bengl3rt could you double check all of these offsets yourself? It would be good to have a second person verifying the accuracy.

@bengl3rt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can definitely confirm the -60 for case D, that's exactly what I had. I'll check the others.

Please sign in to comment.