Added a TODO for another probably data race in effectprocessor.

mixxxdj · Oct 19, 2021 · 3a283b0 · 3a283b0
1 parent 926555d
commit 3a283b0
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/effects/backends/effectprocessor.h b/src/effects/backends/effectprocessor.h
@@ -273,6 +273,11 @@ class EffectProcessorImpl : public EffectProcessor {
         // m_channelStateMatrix may be accessed concurrently in the audio
         // engine thread in loadStatesForInputChannel.
 
+        // TODO: How is ensure that the statMap is not accessed during this loop?
+        // This is called in responds to DISABLE_EFFECT_CHAIN_FOR_INPUT_CHANNEL
+        // and it looks like that the objects pointed by m_channelStateMatrix
+        // may be still in use.
+        // Probably related: https://bugs.launchpad.net/mixxx/+bug/1775497
         ChannelHandleMap<EffectSpecificState*>& stateMap =
                 m_channelStateMatrix[*inputChannel];
         for (EffectSpecificState* pState : stateMap) {