Consolidated EffectChain and EffectChainSlot

- EffectChain and EffectChainSlot had no clear separation of responsibility - Had to keep the duplicated state in both the classes in sync and thus making it more susceptible to bugs NOTE: XML saving/loading of effects is broken and will be re-implemented in the new architecture
mixxxdj · Oct 18, 2018 · 052fd74 · 052fd74
1 parent c9ab901
commit 052fd74
Show file tree

Hide file tree

Showing 21 changed files with 544 additions and 1,196 deletions.
diff --git a/build/depends.py b/build/depends.py
@@ -693,7 +693,6 @@ def sources(self, build):
                    "effects/effectmanifest.cpp",
                    "effects/effectmanifestparameter.cpp",
 
-                   "effects/effectchain.cpp",
                    "effects/effect.cpp",
                    "effects/effectparameter.cpp",
 

diff --git a/src/effects/effectchain.cpp b/src/effects/effectchain.cpp