Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboard shortcuts sheet: add maximize_library #402

Merged
merged 2 commits into from
Jun 30, 2021
Merged

keyboard shortcuts sheet: add maximize_library #402

merged 2 commits into from
Jun 30, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jun 29, 2021

image

@ronso0 ronso0 added this to the 2.3.1 milestone Jun 29, 2021
@ronso0 ronso0 mentioned this pull request Jun 29, 2021
Merged
@ronso0 ronso0 force-pushed the keyboard-sheet-max-lib branch from 5dcd6ec to 038fce0 Compare June 30, 2021 00:13
daschuer
daschuer approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer
Copy link
Member

The broken links are unrelated.

@daschuer
Copy link
Member

daschuer commented Jun 30, 2021 •
edited
Loading

Do you want to update:
chapters/appendix/keyboard_mapping_table.rst as well?

@ronso0
Copy link
Member Author

ronso0 commented Jun 30, 2021

sure.
though it's not clear what that table is for: it has some overlap with the (deck & AutoDJ) mapping graphic but also contains snippets from the app shortcuts (vinyl control). So there are essentially 3 different mapping sheets.

We should find a smart way to re-arrange those, like

  • add a second view to the graphical sheet (app shortcuts) > Help menu + manual "Controlling Mixxx"
  • consolodiate the tables (app table + deck/AutoDJ table) to have a textual, screen-reader-accessible representation
  • tweak the tables to have only 3 columns

@ronso0
Copy link
Member Author

ronso0 commented Jun 30, 2021

#405

@daschuer
Copy link
Member

Thank you for the extra commit and the bug report.

@daschuer daschuer merged commit 8288e0f into mixxxdj:2.3 Jun 30, 2021
@ronso0 ronso0 deleted the keyboard-sheet-max-lib branch June 30, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
basic info
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @daschuer