refactor: Reorganize thumbnail utilities for better maintainability #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved all thumbnail utilities to `utils/thumb-utils` module - All thumbnail utility functions are now within a namespace called `ThumbnailUtils` (the alias is `ThumbUtils`). This change is intended for better module organization and maintainability for feature changes.
- Exported the `ThumbnailUtils` and its alias `ThumbUtils` to the main module. - Exposed several thumbnail utilities to the main module, this includes: - `getAllThumbnails` - `getThumbnailByResolution` and its alias `getThumbnail`
- Relocated all thumbnail utilities' tests to a new test module `thumb-utils.spec.mjs` - Updated the test suites of thumbnail utilities to follow the namespace changes (30fbb44)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 80.33% 80.49% +0.16%
==========================================
Files 10 11 +1
Lines 600 605 +5
==========================================
+ Hits 482 487 +5
Misses 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request refactors the thumbnail utilities in the codebase to improve module organization, maintainability, and clarity. It centralizes thumbnail-related functionality into a single namespace and module, ensuring better scalability for future feature changes.
Changes Made
Codebase Reorganization
utils/thumb-utils.ThumbnailUtilsnamespace, with an aliasThumbUtils.Public API Updates
ThumbnailUtilsand its aliasThumbUtilsfrom the main module for external use.getAllThumbnailsgetThumbnailByResolutionand its aliasgetThumbnailUnit Test Reorganization
thumb-utils.spec.mjs.Impact
ThumbnailUtilsnamespace and its key functions provides a more intuitive interface for developers.Summary
This refactor enhances the maintainability and scalability of the codebase by organizing all thumbnail-related utilities into a dedicated module and namespace.
Tests have been updated to align with these changes, ensuring smooth integration. This PR makes the codebase cleaner and more developer-friendly.