fix: Enhance thumbnail retriever to support author thumbnails #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the `getAuthorThumbnails` function to ensure `videoDetails.author.thumbnails` is an array before accessing it. - Updated `getVideoThumbnails` to check if `videoDetails.thumbnails` is an array for consistent thumbnail retrieval. - Enhanced getThumbnailByResolution logic: - Added fallback mechanism to handle author thumbnails, recognizing their distinct properties (e.g., square dimensions or size parameters in URLs). - Improved resolution type fallback for cases where `max` is unavailable, defaulting to `high`. - Refactored key-matching logic to ensure more reliable thumbnail retrieval. - Introduced conditional handling for thumbnails with atypical dimensions (e.g., square resolutions). - Improved type validation for author and video thumbnail objects to prevent potential runtime errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses issues with the thumbnail retriever functions by adding support for author thumbnails, which have a different structure compared to video thumbnails. The changes enhance the logic to correctly identify and retrieve thumbnails for both video and author entities, ensuring broader compatibility and improved functionality.
Changes Made
getAuthorThumbnailsthumbnailsfrom theauthorobject if the property exists and is an array.getVideoThumbnailsthumbnailsdirectly from video details.getThumbnailByResolution'high'as the default when'max'is unavailable.Impact
Summary
This PR resolves inconsistencies in thumbnail retrieval by enhancing the retriever logic for both video and author thumbnails. It introduces targeted fixes and fallback mechanisms to handle edge cases, ensuring the library provides accurate and reliable thumbnails across different use cases.
Related changes: #84