Configure ESLint and ESLint CI 🤖 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also added a script to invoke the linter in package.json
This changes was made to fix several lint errors and warnings, and improving code maintainablity and readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Added the ESLint package as a development dependency and included a script in the
package.jsonfile to invoke the linter.Added ESLint configuration file for the project.
Added an ESLint ignore file to specify files and directories to be excluded from linting.
Addressed various lint errors and warnings, aiming to enhance code maintainability and readability.
Refactored the
getVideosInfofunction to eliminate the use of an async function as the executor in the Promise constructor, addressing the'no-async-promise-executor'linting error.Setted up the ESLint workflow for the project.
All commits
getVideosInfofunctioneslintpackage as dev dependencySummary
These changes introduce ESLint to the project, addressing lint errors and warnings, enhancing code quality, and establishing a linting workflow for ongoing development. The
getVideosInfofunction has been refactored to conform to linting rules, specifically eliminating the'no-async-promise-executor'issue. The ESLint configuration and ignore files are also added to tailor linting behavior for the project.