Improve error handling and refactor URL validation #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the `extractVideoId` function checks for null or undefined `videoId` before validating it, preventing unexpected errors.
- Replaced the error thrown for invalid URLs in `getVideosInfo` with a more appropriate `URIError`. - Updated `writeErrorLog` to reject the promise on stream error and handle finish event cleanly.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes
This pull request addresses the following changes:
Fixes
writeErrorLog:writeErrorLogfunction to include a reject handler for stream errors. This ensures that any error encountered during the logging process is properly handled, preventing unhandled exceptions and potential race conditions.extractVideoIdfunction by adding an additional check fornullorundefinedvideo IDs before validation. This change prevents potential errors when extracting the video ID from a malformed or incomplete URL.Refactors
ytdl.validateURLwithURLUtils.validateUrlwithin thegetVideosInfofunction. This change leverages the project's utility functions for consistent URL validation and better error handling.Summary
This set of changes aims to enhance the reliability and maintainability of the codebase, particularly in error-prone areas such as logging and URL validation