Don't clear unrelated pending snapshots #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For discussion, re mitsuhiko#492. There are tests which confirm that a passing test removes any associated pending snapshot. Also need a test that checks `--unreferenced=delete` also picks up pending snapshots; then we know that running all tests with `--unreferenced=delete` is a catch-all way of removing any pending snapshots. One test fails, re binary snapshots, because it's on the existing behavior. My only reservation is whether I'm missing something, otherwise the proposed behavior seems better.
Needed for a different branch, committing this change to `main`
|
Merging, as it's well tested and positive-expected-value ...and am back online more now, so can revert / iterate if it doesn't work as well as I hoped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion, re #492.
There are tests which confirm that a passing test removes any associated pending snapshot. And a test that checks
--unreferenced=deletepicks up pending snapshots; so running all tests with--unreferenced=deleteis a catch-all way of removing any pending snapshots.My only reservation is whether I'm missing something? Otherwise the proposed behavior seems better.