Properly return a 1 when a threshold is not met #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will <will@dower.dev>
Signed-off-by: Will <will@dower.dev>
Signed-off-by: Will <will@dower.dev>
|
wdower
commented
Feb 18, 2025
| @@ -61,7 +61,8 @@ export abstract class BaseCommand<T extends typeof Command> extends Command { | |||
| if (err.message.includes('See more help with --help')) { | |||
| this.warn(err.message.replace('--help', `\x1B[93m${process.argv.at(-2)} ${process.argv.at(-1)} -h or --help\x1B[0m`)) | |||
| } else { | |||
| this.warn(err) | |||
| console.error(err.message) | |||
| process.exit(1) | |||
There was a problem hiding this comment.
We tried using this.exit instead of process but it dumped the entire stack trace. What we want is a simple error message to stderr and the return code set correctly. Working within oclif doesn't seem to want to allow this.
georgedias
approved these changes
Feb 19, 2025
em-c-rod
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAF CLI should exit with code 1 when a threshold is not met to enable other automation to properly handle its output without having to parse stderr.
Resolves #3298