Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency track mapper #3004

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Dependency track mapper #3004

merged 11 commits into from
Oct 25, 2024

Conversation

Amndeep7
Copy link
Contributor

No description provided.

wdower
wdower previously requested changes Oct 25, 2024
Copy link
Contributor

@wdower wdower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking on the README. other than that LGTM

README.md Outdated
convert dependency_track2hdf Translate a Dependency-Track results FPF file into
a Heimdall Data Format JSON file

OPTIONS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we note which ones are required flags and add the -h help option to make it consistent with the rest? also I think the indentation got screwed up on this one

…he extension of of basecommand, fixed help text

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 Amndeep7 dismissed wdower’s stale review October 25, 2024 22:59

satisfied request to update readme

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 Amndeep7 merged commit 300360b into main Oct 25, 2024
10 of 11 checks passed
Copy link

@Amndeep7 Amndeep7 deleted the dependency-track-mapper branch October 25, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants