Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new UI #2260

Merged
merged 197 commits into from
Sep 17, 2021
Merged

Update to new UI #2260

merged 197 commits into from
Sep 17, 2021

Conversation

argaudreau
Copy link
Contributor

Description

Co-MR author: @iguannalin

This mega-MR updates the look and feel of CALDERA. The big changes are:

  • Swapping jQuery to AlpineJS
  • Using Bulma.io as the front-end framework (css only)
  • Every core UI template has been updated

Some of the plugins have not been updated to the new UI, and may cause some functionality to break. @iguannalin and I will be tackling the rest of the plugins next.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

We have extensively tested all functionality of the new pages to ensure existing features continued to work, as well as new ones. This included deploying agents, modifying adversaries & abilities, running operations, changing system configurations, testing & adding plugins, etc.

Checklist:

  • My code follows the style guidelines of this project
  • We have performed a self-review of my own code
  • We have made corresponding changes to the documentation
  • We have added tests that prove my fix is effective or that my feature works

argaudreau and others added 30 commits June 8, 2021 10:20
…in now works, though it might still throw some errors, possible due to alpine js being loaded twice)
…ll need to remove/update those to JS later as the other templates in core are dependent on them
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo! Your first PR -- thanks for contributing!

iguannalin
iguannalin previously approved these changes Sep 17, 2021
conf/agents.yml Outdated Show resolved Hide resolved
conf/payloads.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #2260 (cf6f0d3) into master (7974427) will decrease coverage by 0.27%.
The diff coverage is 13.15%.

❗ Current head cf6f0d3 differs from pull request most recent head 1eb7916. Consider uploading reports for the commit 1eb7916 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2260      +/-   ##
==========================================
- Coverage   71.15%   70.88%   -0.28%     
==========================================
  Files          97       97              
  Lines        7450     7483      +33     
==========================================
+ Hits         5301     5304       +3     
- Misses       2149     2179      +30     
Impacted Files Coverage Δ
app/api/rest_api.py 59.29% <ø> (+0.67%) ⬆️
app/api/packs/campaign.py 30.61% <10.81%> (-11.33%) ⬇️
app/objects/c_plugin.py 71.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7974427...1eb7916. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 218 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 67 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

@wbooth wbooth merged commit ffc1341 into master Sep 17, 2021
@wbooth wbooth deleted the new-ui branch September 17, 2021 16:22
@wbooth wbooth restored the new-ui branch September 17, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants