Generate script improvements and runs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing parsing issue Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…sors needs to run after analytics) and ensuring that the directories in /docs they need exist Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…pect the capitalization of the tool as put in the yaml file Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…isted Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…ique based CARs were not rendering properly Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Amndeep7
commented
Feb 15, 2023
| @@ -8,8 +8,7 @@ analytic_type: Situational Awareness, TTP | |||
| contributors: MITRE | |||
| applicable_platforms: Windows | |||
| --- | |||
|
|
|||
There was a problem hiding this comment.
Please confirm if the double break is what is desired over the newlines that were here - this is a change from the template file that's now been consistently applied.
| @@ -60,7 +59,7 @@ The host on which the commands were executed, the time of execution, and what co | |||
| |[Hijack Execution Flow](https://attack.mitre.org/techniques/T1574/)|[Services Registry Permissions Weakness](https://attack.mitre.org/techniques/T1574/011/)|[Persistence](https://attack.mitre.org/tactics/TA0003/), [Privilege Escalation](https://attack.mitre.org/tactics/TA0004/)|Low| | |||
| |[Remote System Discovery](https://attack.mitre.org/techniques/T1018/)|N/A|[Discovery](https://attack.mitre.org/tactics/TA0007/)|Low| | |||
| |[System Services](https://attack.mitre.org/techniques/T1569/)|[Service Execution](https://attack.mitre.org/techniques/T1569/002/)|[Execution](https://attack.mitre.org/tactics/TA0002/)|Low| | |||
| |[Scheduled Task/Job](https://attack.mitre.org/techniques/T1053/)|[At (Windows)](https://attack.mitre.org/techniques/T1053/002/), [Scheduled Task](https://attack.mitre.org/techniques/T1053/005/)|[Persistence](https://attack.mitre.org/tactics/TA0003/), [Privilege Escalation](https://attack.mitre.org/tactics/TA0004/), [Execution](https://attack.mitre.org/tactics/TA0002/)|Low| | |||
There was a problem hiding this comment.
Please confirm if just using 'At', i.e. what's listed in all the source files, is sufficient as opposed to 'At (Windows)'. I'm not sure atm how we would get that information in there - as far as I can tell it seems to have been manually added.
| @@ -69,7 +68,7 @@ The host on which the commands were executed, the time of execution, and what co | |||
| |[System Network Configuration Discovery](https://attack.mitre.org/techniques/T1016/)|N/A|[Discovery](https://attack.mitre.org/tactics/TA0007/)|Low| | |||
| |[Application Window Discovery](https://attack.mitre.org/techniques/T1010/)|N/A|[Discovery](https://attack.mitre.org/tactics/TA0007/)|Low| | |||
| |[Software Discovery](https://attack.mitre.org/techniques/T1518/)|[Security Software Discovery](https://attack.mitre.org/techniques/T1518/001/)|[Discovery](https://attack.mitre.org/tactics/TA0007/)|Low| | |||
| |[Network Service Scanning](https://attack.mitre.org/techniques/T1046/)|N/A|[Discovery](https://attack.mitre.org/tactics/TA0007/)|Low| | |||
There was a problem hiding this comment.
Please confirm that changes to strings like this are correct (Scanning -> Discovery). There are many other CAR files with similar changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.