Cc/search test #3663
Closed
Cc/search test #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const scroller = results.parentNode | ||
| assertInstanceOf(scroller, HTMLElement) | ||
| jest.spyOn(scroller, "offsetParent", "get").mockReturnValue(document.body) | ||
| } |
There was a problem hiding this comment.
Context: Enzyme gives devs access to the react component itself. So you can do stuff like
// call `loadMore` ourselves
wrapper.get(InfiniteScroller).prop('loadMore')()react-testing-library doesn't give you direct access to the components (neither does react, at least via its public api; enzyme gives you access to the components vai react internals). RTL's philosophy is usually: do the "real thing" (click a button; type text, etc) and check that your component responds appropriately. In JSDOM environments (like jest) that's particularly hard. RTL's official recommendation would be "use a real browser environment" for this testing-library/react-testing-library#671 (comment)
|
Superseded by #3669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
app.jsonWhat are the relevant tickets?
(Required)
What's this PR do?
(Required)
How should this be manually tested?
(Required)
Where should the reviewer start?
(Optional)
Any background context you want to provide?
(Optional)
Screenshots (if appropriate)
(Optional)
What GIF best describes this PR or how it makes you feel?
(Optional)