Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update video README with transcoding #2411

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pt2302
Copy link
Contributor

@pt2302 pt2302 commented Feb 6, 2025

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/6559.

Description (What does it do?)

This PR adds documentation about submitting video transcode requests locally, which is required for developing or testing any PRs that include videos submitted to YouTube.

How can this be tested?

Verify that the instructions in the new README section Testing PRs with Transcoding are complete and correct.

@umar8hassan umar8hassan self-assigned this Feb 6, 2025
videos/README.md Outdated

# Testing PRs with Transcoding

When working on or reviewing a PR that requires a video to be uploaded to YouTube, the transcode request needs to be simulated. To do that, first set `API_BEARER_TOKEN` in the `.env` file to some string. Then, use Postman or an equivalent tool to POST a message to `https://localhost:8043/api/transcode-jobs/`, with authorization set to the `API_BEARER_TOEN` and with the body as in [this example](/test_videos_webhook/cloudwatch_sns_complete.json), updated to match the relevant environment variables, course name, and video name.
Copy link
Contributor

@umar8hassan umar8hassan Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pt2302, I think the instructions here are a bit vague. We should mention that the endpoint here simulates a callback from the transcoding service. We should also mention that the sample payload /test_videos_webhook/cloudwatch_sns_complete.json should be updated with relevant values and used after the actual transcoding job with media conversion has been completed. Simulating the callback without job completion may lead to ambiguous states.

Should we put a reference to Matt's PR or bring more details from it regarding AWS setup?

Additionally, the https://localhost:8043/api/transcode-jobs/ endpoint does not require authorization. It allows unrestricted access. I used cURL with only content-type: application/json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 2ab354c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants