Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hover message and new statuses for the site listing page #2407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

umar8hassan
Copy link
Contributor

@umar8hassan umar8hassan commented Jan 30, 2025

What are the relevant tickets?

closes https://github.com/mitodl/hq/issues/6017

Description (What does it do?)

Add the statuses as mentioned on the ticket to the Sites Listing Page

How can this be tested?

  1. Switch to this branch
  2. Go to site listings page on http://localhost:8043/sites/
  3. Create a new site or use an existing one to publish on live.
  4. Check that existing sites have the appropriate statuses shown as below
Screenshot 2025-01-30 at 10 56 41 AM 5. Also check hover is diplayed for statuses in `PublishStatus` enum

Note: Status is updated according to Live Publish Status

@ibrahimjaved12
Copy link
Contributor

@umar8hassan A few things:

  1. Unpublished from Production:
    • Does not show datetime on hover.
    • The status still immediately changes to Unpublished from Production even if the unpublish pipeline fails.
  2. Datetime:
  • It seems very difficult to read with all the attributes present. Could we perhaps use the same timezone that we use in Concourse so that we don't have to utilize tzinfo like this? (and get rid of microsecond as well ?)
    Current behavior: image

  • Also, should we consider changing the rendered text itself on hover? Otherwise it seems a bit difficult to get the datetime on hover, and there's also no way to copy it.
    Like this instead on hover:

image
  1. Draft status:
    • I'm currently unable to get this working.
    • It seems to briefly show for a second when I publish to production instead.
    • When I create a new course and publish to staging, it still shows Never Published. I think it is supposed to show Draft ?
  2. The statuses in listing page do not change in real time, but instead are reflected on page refresh. This is because the listing is fetched once via a Redux Query, so any subsequent status updates aren't automatically reflected in the UI. Should we create a ticket to triage this behavior and determine what changes would be needed to change this?

@pdpinch Could you please look at (2) and (4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants