Add some tests to assert that refactoring worked #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why codecov is giving a warning since this only adds unit tests... |
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 96.51% 96.34% -0.17%
==========================================
Files 8 8
Lines 602 602
==========================================
- Hits 581 580 -1
- Misses 21 22 +1
Continue to review full report at Codecov.
|
Merged
3494b73 to
bad6d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Part of #56
What's this PR do?
Adds tests for parts of master JSON which were previously not covered by unit tests. The tests should show that the data looks good on master so that when we refactor we can know that the new code passes the same tests.
How should this be manually tested?
N/A