update ts; remove suppressImplicitAnyIndexErrors (#68)

* update ts; remove suppressImplicitAnyIndexErrors * update eslint * one more linting update * update node
mitodl · Feb 16, 2024 · 4d45f3c · 4d45f3c
1 parent ca46b7f
commit 4d45f3c
Show file tree

Hide file tree

Showing 5 changed files with 240 additions and 304 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -9,7 +9,7 @@ jobs:
       - name: Set up NodeJS
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 15.3.0
+          node-version: 20.11.1
 
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path

diff --git a/package.json b/package.json
@@ -48,12 +48,12 @@
     "@types/ramda": "^0.27.27",
     "@types/react": "^16.9.49",
     "@types/react-dom": "^16.9.8",
-    "@typescript-eslint/eslint-plugin": "^5.39.0",
-    "@typescript-eslint/parser": "^5.37.0",
+    "@typescript-eslint/eslint-plugin": "^7.0.1",
+    "@typescript-eslint/parser": "^7.0.1",
     "babel-eslint": "10.x",
     "enzyme": "^3.11.0",
     "enzyme-adapter-react-16": "^1.15.4",
-    "eslint": "^7.32.0",
+    "eslint": "^8.56.0",
     "eslint-config-google": "0.x",
     "eslint-config-mitodl": "^1.0.0",
     "eslint-plugin-babel": "5.x",
@@ -71,7 +71,7 @@
     "react": "^16.13.1",
     "react-dom": "^16.13.1",
     "ts-node": "^10.9.1",
-    "typescript": "^4.8.3"
+    "typescript": "^5.3.3"
   },
   "peerDependencies": {
     "@types/history": "^4.9",

diff --git a/src/index.ts b/src/index.ts
@@ -62,7 +62,7 @@ export const useFacetOptions = (
 ): ((group: string) => Aggregation | null) => {
   return useCallback(
     (group: string) => {
-      const emptyActiveFacets = (activeFacets[group] || []).map(
+      const emptyActiveFacets = (activeFacets[group as keyof Facets] || []).map(
         (facet: string) => ({
           key:       facet,
           doc_count: 0
@@ -197,11 +197,12 @@ export const useSearchInputs = (history: HHistory): UseSearchInputsResult => {
       setSearchParams(current => {
         const { activeFacets, sort, ui } = current
         const newFacets = clone(activeFacets)
+        const facetName = name as keyof Facets
 
         if (isEnabled) {
-          newFacets[name] = _.union(newFacets[name] || [], [value])
+          newFacets[facetName] = _.union(newFacets[facetName] || [], [value])
         } else {
-          newFacets[name] = _.without(newFacets[name] || [], value)
+          newFacets[facetName] = _.without(newFacets[facetName] || [], value)
         }
         return {
           ...current,
@@ -222,10 +223,11 @@ export const useSearchInputs = (history: HHistory): UseSearchInputsResult => {
         const newFacets = clone(activeFacets)
 
         facets.forEach(([name, value, isEnabled]) => {
+          const facetName = name as keyof Facets
           if (isEnabled) {
-            newFacets[name] = _.union(newFacets[name] || [], [value])
+            newFacets[facetName] = _.union(newFacets[facetName] || [], [value])
           } else {
-            newFacets[name] = _.without(newFacets[name] || [], value)
+            newFacets[facetName] = _.without(newFacets[facetName] || [], value)
           }
         })
         return {

diff --git a/tsconfig.json b/tsconfig.json
@@ -14,7 +14,6 @@
     "outDir": "./dist/",
     "tsBuildInfoFile": ".tsbuildinfo",
     "strict": true,
-    "suppressImplicitAnyIndexErrors": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitReturns": true,