Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to resolve hostnames and get OS's DNS servers #148

Merged
merged 11 commits into from
Jul 3, 2024
Merged

Add API to resolve hostnames and get OS's DNS servers #148

merged 11 commits into from
Jul 3, 2024

Conversation

errorxyz
Copy link
Member

Addresses step 1 in mitmproxy/mitmproxy#6739

@errorxyz errorxyz mentioned this pull request Jun 29, 2024
Merged
2 tasks
@errorxyz
Copy link
Member Author 

error: mitmproxy_rs.getaddrinfo is not present in stub
Stub: in file /home/runner/.local/lib/python3.10/site-packages/mitmproxy_rs/__init__.pyi
MISSING
Runtime:
def (host, is_ipv6)

How do I fix this test?

@mhils
Copy link
Member

mhils commented Jun 30, 2024 •
edited
Loading 

error: mitmproxy_rs.getaddrinfo is not present in stub
Stub: in file /home/runner/.local/lib/python3.10/site-packages/mitmproxy_rs/__init__.pyi
MISSING
Runtime:
def (host, is_ipv6)

How do I fix this test?

By adding typer annotations for it in the pyi file. :)

@errorxyz errorxyz force-pushed the dns-resolver branch 3 times, most recently from 45277f6 to 1acb703 Compare July 1, 2024 14:44
@errorxyz errorxyz changed the title Add getaddrinfo to resolve domain names Add getaddrinfo and get_system_dns_server Jul 1, 2024
mhils
mhils reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

mitmproxy-rs/src/dns_resolver.rs Outdated Show resolved Hide resolved
mitmproxy-rs/src/dns_resolver.rs Outdated Show resolved Hide resolved
mitmproxy-rs/src/dns_resolver.rs Outdated Show resolved Hide resolved
mitmproxy-rs/src/dns_resolver.rs Outdated Show resolved Hide resolved
mitmproxy-rs/src/dns_resolver.rs Outdated Show resolved Hide resolved
@mhils mhils force-pushed the dns-resolver branch 3 times, most recently from dae9d5a to 3d576cb Compare July 2, 2024 23:20
@mhils mhils marked this pull request as ready for review July 2, 2024 23:29
@mhils mhils merged commit dd8db95 into mitmproxy:main Jul 3, 2024
18 checks passed
@errorxyz errorxyz changed the title Add getaddrinfo and get_system_dns_server Add API to resolve hostnames and get OS's DNS servers Jul 3, 2024
@errorxyz errorxyz deleted the dns-resolver branch December 9, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhils mhils mhils left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errorxyz @mhils