-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/comments web UI #6709
Feature/comments web UI #6709
Conversation
if you like it, I can then update the tests. Let me know :) thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks!
@mhils I made a change in the this is the change:
|
app.css is autogenerated from the less files. So you want to modify the less files in https://github.com/mitmproxy/mitmproxy/tree/main/web/src/css and keep app.css as-is. It will be automatically updated on the next release. :) |
ahhh I see now, thank you ! |
c2eeb78
to
ba05efb
Compare
@mhils Is there a reason why the folder |
a) looks like we can remove the editors exclusion. |
Okay thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
The more I look at it the more I want to merge it with the Timings pane, but let's resist the urge and get this in first. :)
it("should be possible to get a comment", () => { | ||
let tflow = TFlow(); | ||
expect(tflow.comment).toEqual("I'm a comment!"); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover
Alright :) I'll do it in the future, I promise ahah. For the coverage ? Is it fine ? |
Description
Added the possibility to add a comment as a column in the flow table. Then, added a section in the flow details panel where we can see and modify the comment. I modified the backend as well since we were not supporting the modification of a comment. I hope the way I did it is correct :)
closes : #6708
Checklist