Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed no_grad statement from GP forward method and moved model to device in gp #42

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Removed no_grad statement from GP forward method and moved model to device in gp #42

merged 4 commits into from
Feb 7, 2024

Conversation

gtbotkin
Copy link
Collaborator

@gtbotkin gtbotkin commented Feb 1, 2024

No description provided.

@gtbotkin gtbotkin changed the title Initial commit -- removed no_grad statement from GP forward method Removed no_grad statement from GP forward method and moved model to device in gp Feb 1, 2024
@gtbotkin gtbotkin self-assigned this Feb 7, 2024
@gtbotkin gtbotkin marked this pull request as draft February 7, 2024 18:44
@gtbotkin gtbotkin marked this pull request as ready for review February 7, 2024 20:45
nukularrr
nukularrr approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@nukularrr nukularrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and passes all tests

@nukularrr nukularrr merged commit 05af3c5 into main Feb 7, 2024
8 checks passed
@nukularrr nukularrr deleted the add_grad_gp_forward branch February 7, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nukularrr nukularrr nukularrr approved these changes

Assignees

@gtbotkin gtbotkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtbotkin @nukularrr