Added a check for way < num_class #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed some doc items Fixes #15
|
Wasn't the plan to do a require statement? What changed your mind? |
nukularrr
added a commit
that referenced
this pull request
Aug 3, 2023
After merging #16, the tests began failing due to a typeguard error checking that a dictionary actually produces key, val pairs as a returned item in `generate_support` in `utils.py`. I used the opportunity to refactor that call to only ever return a dict by making it optional to pass in the shuffled indexes (only used internally in generate_episode, anyway), saving a second call to `torch.unique`. Upon finding an issue in typeguard that appeared at the same time as their upstream release and our error, I restricted the typeguard version to be 4.0 or lower. Refs #17
nukularrr
added a commit
that referenced
this pull request
Aug 3, 2023
After merging #16, the tests began failing due to a typeguard error checking that a dictionary actually produces key, val pairs as a returned item in `generate_support` in `utils.py`. I used the opportunity to refactor that call to only ever return a dict by making it optional to pass in the shuffled indexes (only used internally in generate_episode, anyway), saving a second call to `torch.unique`. Upon finding an issue in typeguard that appeared at the same time as their upstream release and our error, I restricted the typeguard version to be 4.0 or lower. Refs #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #15