Fix missing action bar in Device Default theme #3304
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I522e6d907dedaf8284777b6a7feb08b7720200ef
fbfd268 to
400ca03
Compare
|
Rebased onto latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I522e6d907dedaf8284777b6a7feb08b7720200ef
General items:
ant testspasses on my machineFor all other changes:
mastermasteras the baseWhat does this PR accomplish?
This PR fixes #3075. When the default theme was changed from Classic to Device Default, the logic for setting the
classic-modeflag in YAIL was no longer correct since it assumes that the default setting is Classic. Now, the 'Theme' property is empty when in Device Default and we should only set the classic mode flag for 'Classic' theme.This only affects compiled apps so it submitted against master.