-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): tabler-iconsが読み込めない問題を修正(暫定的対応) #15332
Merged
mi-gh-maintainer
merged 5 commits into
misskey-dev:develop
from
kakkokari-gtyih:fix-14364
Jan 28, 2025
Merged
fix(frontend): tabler-iconsが読み込めない問題を修正(暫定的対応) #15332
mi-gh-maintainer
merged 5 commits into
misskey-dev:develop
from
kakkokari-gtyih:fix-14364
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15332 +/- ##
============================================
- Coverage 38.70% 18.83% -19.88%
============================================
Files 1603 764 -839
Lines 204284 111027 -93257
Branches 4015 1233 -2782
============================================
- Hits 79069 20907 -58162
+ Misses 124609 89533 -35076
+ Partials 606 587 -19 ☔ View full report in Codecov by Sentry. |
5 tasks
anatawa12
approved these changes
Jan 25, 2025
コンフリクト解消 |
2025.1.0に入れちゃいたい気もする |
2c3a41e
into
misskey-dev:develop
22 of 23 checks passed
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
tabler-iconsを、フォントspecに適合した自前ビルドに置き換え( https://github.com/misskey-dev/tabler-icons )
upstreamとの違い:
Why
#10371, #14364 への暫定的対応
tabler-icons側で修正が入ったらそちらに戻すべし
Additional info (optional)
Checklist