Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): tabler-iconsが読み込めない問題を修正(暫定的対応) #15332

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 23, 2025

What

tabler-iconsを、フォントspecに適合した自前ビルドに置き換え( https://github.com/misskey-dev/tabler-icons

upstreamとの違い:

Why

#10371, #14364 への暫定的対応
tabler-icons側で修正が入ったらそちらに戻すべし

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 23, 2025
@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Jan 23, 2025

gfx.downloadable_fonts.otl_validation が有効なFirefoxでアイコンが表示されることを確認

image

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.83%. Comparing base (605756d) to head (f32695c).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15332       +/-   ##
============================================
- Coverage    38.70%   18.83%   -19.88%     
============================================
  Files         1603      764      -839     
  Lines       204284   111027    -93257     
  Branches      4015     1233     -2782     
============================================
- Hits         79069    20907    -58162     
+ Misses      124609    89533    -35076     
+ Partials       606      587       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@anatawa12
Copy link
Member

2025.1.0に入れちゃいたい気もする

@mi-gh-maintainer mi-gh-maintainer bot merged commit 2c3a41e into misskey-dev:develop Jan 28, 2025
22 of 23 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-14364 branch January 28, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants