Search country flags using country names #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Always match on emoji character * For flag emojis where emojiLib data is found, use emojiLib name
Always perform the capitalization-correction for country names. If we did this naïvely, using the same regex as before, it would change things like "Falkland Islands" to "Falkland ISLANDS". The new regex checks on word boundary, `\b`, instead of space, `\s`, which means even single words like `Eu` are found. It then checks for exactly two letters, where the first is uppercase and the second lowercase. Here's exactly what it affects: * All "Regional Indicator Symbol Letters AC"-type names that don't have data in emojiLib * There are some flags in emojiLib for which it uses two-character abbreviations instead of full country names (see muan/emojilib#131). These countries are: CN, EU, FR, DE, IT, JP, RU, KR, ES, TR, UK, US This new regex corrects these from Cn, Eu, Fr, etc.
|
This looks great @chadoh, I’ll do a thorough review ASAP! |
|
That’s perfect, thanks again @chadoh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #96.
This works around current limitations/inconsistences in
emoji-dataandemojilibby matching between the two libraries on the emoji character itself, rather than relying on a perfect match between the two disparate "short name" fields.See individual commit messages, especially for a927821, for extra info.
Demo of new functionality: