fix: Use getDerivedStateFromProps instead of componentWillReceiveProps (

#372) * use getDerivedStateFromProps instead of componentWillReceiveProps * code formatting
missive · Dec 21, 2019 · 208099c · 208099c
1 parent f10510b
commit 208099c
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/components/picker/nimble-picker.js b/src/components/picker/nimble-picker.js
@@ -176,12 +176,19 @@ export default class NimblePicker extends React.PureComponent {
     this.handleKeyDown = this.handleKeyDown.bind(this)
   }
 
-  componentWillReceiveProps(props) {
+  static getDerivedStateFromProps(props, state) {
     if (props.skin) {
-      this.setState({ skin: props.skin })
+      return {
+        ...state,
+        skin: props.skin,
+      }
     } else if (props.defaultSkin && !store.get('skin')) {
-      this.setState({ skin: props.defaultSkin })
+      return {
+        ...state,
+        skin: props.defaultSkin,
+      }
     }
+    return state
   }
 
   componentDidMount() {