Add missing filters when listing issues. #1234
Conversation
| When opening an issue, add a comma-separated list of labels to this issue. | ||
|
|
||
| -t, --since <TIME> | ||
| Display only issues updated at or after a certain time. The time is a |
There was a problem hiding this comment.
Maybe instead of "time" we can say "date" and allow a date input without a time?
|
This looks great! Thanks for working on this. |
| "creator": flagIssueCreator, | ||
| "mentioned": flagIssueMentioned, | ||
| "labels": flagIssueLabelsFilter, | ||
| "since": flagIssueSince, |
There was a problem hiding this comment.
I still think we need to process flagIssueSince a bit before passing it on to the API. The reason is timezones.
A person in New Zealand might use 2016-08-19 to get all isues on or after Friday. However, when the API interprets that date, most likely in the PST timezone, the results returned from start of Friday will be very different, ignoring most issues opened on Friday in New Zealand.
We have to assume that when a person doesn't specify a time or timezone offset, 2016-08-19 means “the start of the 19th of August for me in my local timezone“. So, we should parse the date in the local timezone, have it default to 00:00:00 for time, and serialize it into ISO 8601 format when passing to API so the time is absolutely precise and unambiguous.
Useful for #1099